Do you then prefer those debugger functions to fail with an exception or just silently?
On Sat, Oct 17, 2015, 12:59 Ben Noordhuis <[email protected]> wrote: > On Fri, Oct 16, 2015 at 11:18 AM, Yang Guo <[email protected]> wrote: > > The debugger's JS API is supposed to be just that, an API to build upon. > > You'd expect the C++ API to crash on CHECK failures as well, right? > Also, I > > wouldn't call illegal access exceptions great experience for embedders > > either. Maybe we can turn select ones into more descriptive exceptions? > > > > Yang > > The reason I bring it up is that I'm aware of at least one module that > uses illegal access exceptions as a weathervane for coexisting with > other debug packages (if Debug.scripts() throws an exception, no > debugger is active yet.) That would break rather horribly with the > proposed changes. > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
