Hey Ben! Thanks for the feedback, that's exactly the kind of use-cases I am interested in. I have added a test[1] to make sure I am not regressing this use-case with my proposed change. In the beginning we will keep throwing the "illegal access" string. As Yang already mentioned, it might make sense to use dedicated exceptions/strings (or even some other error reporting) for the debugger, but that is outside the scope of my change.
Please let me know if there are other use-cases like this one that we need to be aware of or watch out for. Thanks! [1] https://codereview.chromium.org/1411193002/ Best regards, Michael On Mon, Oct 19, 2015 at 6:45 AM, Yang Guo <[email protected]> wrote: > Do you then prefer those debugger functions to fail with an exception or > just silently? > > On Sat, Oct 17, 2015, 12:59 Ben Noordhuis <[email protected]> wrote: > >> On Fri, Oct 16, 2015 at 11:18 AM, Yang Guo <[email protected]> wrote: >> > The debugger's JS API is supposed to be just that, an API to build upon. >> > You'd expect the C++ API to crash on CHECK failures as well, right? >> Also, I >> > wouldn't call illegal access exceptions great experience for embedders >> > either. Maybe we can turn select ones into more descriptive exceptions? >> > >> > Yang >> >> The reason I bring it up is that I'm aware of at least one module that >> uses illegal access exceptions as a weathervane for coexisting with >> other debug packages (if Debug.scripts() throws an exception, no >> debugger is active yet.) That would break rather horribly with the >> proposed changes. >> >> -- >> -- >> v8-dev mailing list >> [email protected] >> http://groups.google.com/group/v8-dev >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
