https://codereview.chromium.org/1309813007/diff/590001/src/parsing/parser.cc
File src/parsing/parser.cc (right):
https://codereview.chromium.org/1309813007/diff/590001/src/parsing/parser.cc#newcode4549
src/parsing/parser.cc:4549:
!rw->IsRewritableAs(RewritableExpression::kDestructuringAssignment)) {
On 2015/12/01 22:42:56, adamk wrote:
It's checks like this that I don't see as terribly useful, since
they're always
true.
the check is checking 2 things: 1, that it's "possibly" a destructuring
assignment (eg, valid syntax), and 2, that it hasn't already been
rewritten as a destructuring assignment.
While the first check could probably go away until more things need to
use it (which hopefully never happens, admittedly), the second one is
pretty important to make sure there's no endless looping (or hitting
UNREACHABLEs and crashing)
https://codereview.chromium.org/1309813007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
