lgtm once nits are taken care of and the CL description is trimmed
down/rewritten to match reality (for one, this is much more than a parsing
patch
now).
Will also need some OWNERS in Munich, adding bmeurer who's in all the
relevant
files.
A few nits below.
https://codereview.chromium.org/1309813007/diff/710001/src/ast/ast.h
File src/ast/ast.h (right):
https://codereview.chromium.org/1309813007/diff/710001/src/ast/ast.h#newcode406
src/ast/ast.h:406: class RewritableExpression : public Expression {
This got lost in the back-and-forth, but now that this is less-generic,
I think this should be called "RewritableAssignmentExpression"
https://codereview.chromium.org/1309813007/diff/710001/src/ast/ast.h#newcode3585
src/ast/ast.h:3585: RewritableExpression*
NewRewritableExpression(Expression* expression) {
And this should take an Assignment*
https://codereview.chromium.org/1309813007/diff/710001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/1309813007/diff/710001/src/flag-definitions.h#newcode211
src/flag-definitions.h:211: V(harmony_destructuring_assignment, "harmony
destructuring assignment")
Does this need to imply harmony_destructuring_bind?
https://codereview.chromium.org/1309813007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
