There are VS project files for arm simulator and x64 too.

I prefer to have the Visit methods of the code generator more or less ordered as
they are in ast.h, at least with expressions all together and statements all
together.

LGTM as a temporary solution.


http://codereview.chromium.org/646019/diff/1/4
File src/fast-codegen.h (right):

http://codereview.chromium.org/646019/diff/1/4#newcode33
src/fast-codegen.h:33: #include "ast.h"
Unless you think these includes will not diverge for the different
platforms, I think they should go in fast-codegen-ia32.h and below the
#else.

ia32 shouldn't get anything from this file.

http://codereview.chromium.org/646019/diff/1/4#newcode36
src/fast-codegen.h:36: #if V8_TARGET_ARCH_IA32
#ifdef

http://codereview.chromium.org/646019

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to