The arm and x64 VS project files should be the same (no new files there).


http://codereview.chromium.org/646019/diff/1/4
File src/fast-codegen.h (right):

http://codereview.chromium.org/646019/diff/1/4#newcode33
src/fast-codegen.h:33: #include "ast.h"
On 2010/02/18 19:30:24, Kevin Millikin wrote:
Unless you think these includes will not diverge for the different
platforms, I
think they should go in fast-codegen-ia32.h and below the #else.

ia32 shouldn't get anything from this file.

Done.

http://codereview.chromium.org/646019/diff/1/4#newcode36
src/fast-codegen.h:36: #if V8_TARGET_ARCH_IA32
On 2010/02/18 19:30:24, Kevin Millikin wrote:
#ifdef

Does it make a difference? I just copied this preprocessor-directives
from frames-inl.h

http://codereview.chromium.org/646019

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to