Great work, thank you! Some questions: You only added the initialization call to d8. Will this also work for other binaries / when run inside chromium?
You also stripped out the libsymbolize specific code. Is there some functionality we're now missing? Last but not least, I guess you can now remove the v8_enable_backtrace and related settings, no? On Thu, Aug 18, 2016 at 5:57 PM 'Ross McIlroy' via v8-dev < [email protected]> wrote: > This has now landed. > > Cheers > > > Ross > > On 18 Aug 2016 12:56 p.m., "Ross McIlroy" <[email protected]> wrote: > >> Hi all, >> >> *tldr; C stack trace output will change, but we will now get dumps on >> Windows and on signals / uncaught C++ exceptions in d8.* >> >> I'm planing on landing https://codereview.chromium.org/2248393002/ sometime >> later today. This change removes our current DumpBacktrace code (which only >> worked on Linux) and replaces it with the implementation used by Chromium. >> >> This will give us dumps on Windows. It also enables in-process stack >> dumping on uncaught signals (e.g., SEGV) or Window's C++ exceptions. I have >> only enabled in-process stack dumping on signals in the d8 shell (other >> embedded won't be effected). >> >> This shouldn't impact day-to-day debugging (gdb still works as before - >> see CL comments for details), but should give us some debug information for >> crashes on the Windows bots [1]. >> >> As a consequence of this change, the output format of C stack traces >> (e.g., on CHECK failures) will change somewhat. The new format is a bit >> more verbose, but contains the same information as before (see CL for >> details). >> >> Unless anyone objects, I'll land this CL later today. >> >> Cheers, >> Ross >> >> [1] I'm currently trying to debug a crash which only happens on a single >> Windows bot, and doesn't repo locally or on the try-bots. A stack-trace >> would be really useful for this :). >> > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
