On 22 August 2016 at 10:23, Jochen Eisinger <[email protected]> wrote:
> Great work, thank you! > > Some questions: > You only added the initialization call to d8. Will this also work for > other binaries / when run inside chromium? > The EnableInProcessStackDumping initialize is for enabling stack dumping on signals (or Windows exceptions). We could add this to other binaries (cctests and unittests) if that is deemed useful? We should't call it from Chromium though, since Chromium has it's own signal handlers (e.g., BreakPad) and we shouldn't interfere with that. Regardless, V8_Fatal or CHECK will always dump the stack regardless of whether EnableInProcessStackDumping is called or not, so we have the same coverage as previously regardless. > You also stripped out the libsymbolize specific code. Is there some > functionality we're now missing? > I don't think we are missing anything compared to what we had before. We get symbolized crashes for debug builds on Linux but release builds are unsymbolized (we didn't get symbolized crashes for release builds before this change either). On windows it looks like we get symbolized crashes for both release and debug. I removed the libsymbolize specific code because I didn't want to pull in too many dependencies. Currently the stack dumps on signals in Linux are unsymbolized because the symbolization code is not async-signal safe. It looks like libsymbolize could fix this, I'll take a look and see if it is easy enough to add back in. > Last but not least, I guess you can now remove the v8_enable_backtrace and > related settings, no? > Hmm, not without libsymbolize I don't think. The main difference this does is change the symbol visibility, and it looks like we still need this in order to symbolize (at least on Linux). > On Thu, Aug 18, 2016 at 5:57 PM 'Ross McIlroy' via v8-dev < > [email protected]> wrote: > >> This has now landed. >> >> Cheers >> >> >> Ross >> >> On 18 Aug 2016 12:56 p.m., "Ross McIlroy" <[email protected]> wrote: >> >>> Hi all, >>> >>> *tldr; C stack trace output will change, but we will now get dumps on >>> Windows and on signals / uncaught C++ exceptions in d8.* >>> >>> I'm planing on landing https://codereview.chromium.org/2248393002/ sometime >>> later today. This change removes our current DumpBacktrace code (which only >>> worked on Linux) and replaces it with the implementation used by Chromium. >>> >>> This will give us dumps on Windows. It also enables in-process stack >>> dumping on uncaught signals (e.g., SEGV) or Window's C++ exceptions. I have >>> only enabled in-process stack dumping on signals in the d8 shell (other >>> embedded won't be effected). >>> >>> This shouldn't impact day-to-day debugging (gdb still works as before - >>> see CL comments for details), but should give us some debug information for >>> crashes on the Windows bots [1]. >>> >>> As a consequence of this change, the output format of C stack traces >>> (e.g., on CHECK failures) will change somewhat. The new format is a bit >>> more verbose, but contains the same information as before (see CL for >>> details). >>> >>> Unless anyone objects, I'll land this CL later today. >>> >>> Cheers, >>> Ross >>> >>> [1] I'm currently trying to debug a crash which only happens on a single >>> Windows bot, and doesn't repo locally or on the try-bots. A stack-trace >>> would be really useful for this :). >>> >> -- >> -- >> v8-dev mailing list >> [email protected] >> http://groups.google.com/group/v8-dev >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
