LGTM
http://codereview.chromium.org/650136/diff/1/2 File src/x64/assembler-x64.cc (left): http://codereview.chromium.org/650136/diff/1/2#oldcode39 src/x64/assembler-x64.cc:39: Register rax = { 0 }; Are you sure we shouldn't still have a definition here, just without the value? http://codereview.chromium.org/650136/diff/1/4 File src/x64/assembler-x64.h (left): http://codereview.chromium.org/650136/diff/1/4#oldcode165 src/x64/assembler-x64.h:165: extern MMXRegister mm15; And good riddance to MMX! http://codereview.chromium.org/650136/diff/1/4 File src/x64/assembler-x64.h (right): http://codereview.chromium.org/650136/diff/1/4#newcode118 src/x64/assembler-x64.h:118: int code_; Could we make it const? http://codereview.chromium.org/650136 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
