http://codereview.chromium.org/650136/diff/1/2 File src/x64/assembler-x64.cc (left):
http://codereview.chromium.org/650136/diff/1/2#oldcode39 src/x64/assembler-x64.cc:39: Register rax = { 0 }; On 2010/02/22 11:36:40, Lasse Reichstein wrote:
Are you sure we shouldn't still have a definition here, just without
the value? Yes. Those weren't class static members, they were global variables. http://codereview.chromium.org/650136/diff/1/4 File src/x64/assembler-x64.h (right): http://codereview.chromium.org/650136/diff/1/4#newcode118 src/x64/assembler-x64.h:118: int code_; On 2010/02/22 11:36:40, Lasse Reichstein wrote:
Could we make it const?
The whole struct is const in all its accessors. We are making it const by not making it mutable. http://codereview.chromium.org/650136 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
