Unfortunately adding "%DebugPrint(requestedLocale);" in intl.js in CreateNumberFormat() does not show anything in android logcat. Should i do anything specific?
On Monday, June 4, 2018 at 1:37:35 PM UTC+5, Jakob Gruber wrote: > > > > On Sat, Jun 2, 2018 at 2:02 PM, <[email protected] <javascript:>> > wrote: > >> Hey, guys. >> >> I'm working on Chromium fork and i'm having really weird behaviour - i >> don't have any issues in Debug mode, >> but in Release mode i'm, getting the following fatal >> <https://cs.chromium.org/chromium/src/v8/src/objects/intl-objects.cc?type=cs&q=%22Failed+to+create+ICU+number+format,+are+ICU+data+files+missing?%22&sq=package:chromium&g=0&l=893> >> : >> > Failed to create ICU number format, are ICU data files missing? >> >> I've found "locale" variable is "und" in Release mode, but "ru" (expected >> value) in Debug mode in "Runtime_CreateNumberFormat": >> <https://cs.chromium.org/chromium/src/v8/src/runtime/runtime-intl.cc?type=cs&q=Runtime_CreateNumberFormat&g=0&l=285> >> I wonder where "locale" variable comes from? >> >> Any documentation links or explanation is highly appreciated. >> > > The locale variable is passed in from the single callsite in intl.js [0]. > You should start digging there with printf-style debugging using > %DebugPrint. > > [0] > https://cs.chromium.org/chromium/src/v8/src/js/intl.js?l=1373&rcl=9b39cfe022a85a3e9bdd08d27bac7365ceb6208e > > >> >> BTW. I've patched >> <https://github.com/adblockplus/v8-googlesource/commit/8230b69454fc852bad9d6658d621f0d704276dca> >> >> V8 to make it compilable as for "component build" as shared library even >> for Chromium non-component build (i can explain if required). >> Did i make anything wrong here? >> > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
