That would be good. Just wanted to mention that i'm working with v8 Version 6.5.254.28, probably it makes sense to check the most recent version.
On Wednesday, June 6, 2018 at 4:38:05 PM UTC+5, Clemens Hammacher wrote: > > This is unfortunate indeed. I opened a bug for this ( > https://crbug.com/v8/7820) and prepared a fix to make %DebugPrint work > properly on Android. > > On Wed, Jun 6, 2018 at 1:20 PM <[email protected] <javascript:>> > wrote: > >> I've found v8_android_log_stdout >> <https://cs.chromium.org/chromium/src/v8/BUILD.gn?type=cs&q=v8_android_log_stdout&g=0&l=23> >> >> and investigated how it's working, pretty straight-forward. >> >> So this is modified version of v8 debug output working on android (JIC): >> >> RUNTIME_FUNCTION(Runtime_AndroidDebugPrint) { >> >> HandleScope scope(isolate); >> >> DCHECK_EQ(1, args.length()); >> >> CONVERT_ARG_HANDLE_CHECKED(String, message, 0); >> >> v8::internal::PrintF("MyFork: v8_debug: %s\n", message->ToCString().get >> ()); >> >> return 0; >> } >> >> >> On Saturday, June 2, 2018 at 5:02:59 PM UTC+5, [email protected] >> wrote: >>> >>> Hey, guys. >>> >>> I'm working on Chromium fork and i'm having really weird behaviour - i >>> don't have any issues in Debug mode, >>> but in Release mode i'm, getting the following fatal >>> <https://cs.chromium.org/chromium/src/v8/src/objects/intl-objects.cc?type=cs&q=%22Failed+to+create+ICU+number+format,+are+ICU+data+files+missing?%22&sq=package:chromium&g=0&l=893> >>> : >>> > Failed to create ICU number format, are ICU data files missing? >>> >>> I've found "locale" variable is "und" in Release mode, but "ru" >>> (expected value) in Debug mode in "Runtime_CreateNumberFormat": >>> <https://cs.chromium.org/chromium/src/v8/src/runtime/runtime-intl.cc?type=cs&q=Runtime_CreateNumberFormat&g=0&l=285> >>> I wonder where "locale" variable comes from? >>> >>> Any documentation links or explanation is highly appreciated. >>> >>> BTW. I've patched >>> <https://github.com/adblockplus/v8-googlesource/commit/8230b69454fc852bad9d6658d621f0d704276dca> >>> >>> V8 to make it compilable as for "component build" as shared library even >>> for Chromium non-component build (i can explain if required). >>> Did i make anything wrong here? >>> >> -- >> -- >> v8-dev mailing list >> [email protected] <javascript:> >> http://groups.google.com/group/v8-dev >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > -- > > Clemens Hammacher > > Software Engineer > > [email protected] <javascript:> > > Google Germany GmbH > > Erika-Mann-Straße 33 > > 80636 München > > Geschäftsführer: Paul Manicle, Halimah DeLaine Prado > > Registergericht und -nummer: Hamburg, HRB 86891 > > Sitz der Gesellschaft: Hamburg > > Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten > haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, > löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, > dass die E-Mail an die falsche Person gesendet wurde. > > > > This e-mail is confidential. If you received this communication by > mistake, please don't forward it to anyone else, please erase all copies > and attachments, and please let me know that it has gone to the wrong > person. > > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
