http://codereview.chromium.org/651029/diff/1006/48 File src/arm/simulator-arm.cc (right):
http://codereview.chromium.org/651029/diff/1006/48#newcode563 src/arm/simulator-arm.cc:563: return v + ((v & 1) ? + Instr::kPCReadOffsetThumb : Instr::kPCReadOffset); There's a stray '+' here and the (v & 1) thing needs to be in its own method called IsInThumbMode. When you do that method remember not to use implicit bool conversion. http://codereview.chromium.org/651029/diff/1006/48#newcode2159 src/arm/simulator-arm.cc:2159: result >>= (shift_amount - 1); Can shift_amount be zero? If so how does this work. If not, then please assert that it is not zero. http://codereview.chromium.org/651029/diff/1006/48#newcode2204 src/arm/simulator-arm.cc:2204: // enter_debug_ = true; Please no commented out code. http://codereview.chromium.org/651029/diff/1006/48#newcode2320 src/arm/simulator-arm.cc:2320: } else if (program_counter & 1) { Why only if program_counter & 1? (And implicit conversion) http://codereview.chromium.org/651029 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
