http://codereview.chromium.org/651029/diff/1006/55 File src/arm/instr-thumb2.cc (right):
http://codereview.chromium.org/651029/diff/1006/55#newcode40 src/arm/instr-thumb2.cc:40: if (Bits0(15, 13) == b111 && Bits0(12, 11) != b00) { We don't feel these bxxx constants add enough in terms of clarity to compensate for their strangeness. Please use hex throughout. If possible of course the constants should have real names. Any opcode in table A6-1 and the tables on the following pages should have a name. In this case it would be clearer to write: if (Bits(15, 11) > kMax16BitThumbOpcode) where kMax16BitThumbOpcode is 0x1c, from table A6-1. http://codereview.chromium.org/651029 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
