The commands seem fine. Goma is just a way to speed up the build process, it is in no way required for correct results.
Maybe the "unrelated" assert failures are not as unrelated as they seem. In fact, the output looks a bit like an assert failure. While I don't see what exactly is wrong, I would guess that something is wrong with the change(s) you made. Do the same changes work in a standalone V8 checkout/build? You can test Array.join in d8, no need for full Chromium and document.write() ;-) On Fri, Nov 2, 2018 at 2:19 AM <[email protected]> wrote: > I'm seeing some strange behavior when making a change to v8 and rebuilding > Chromium. > I make a small change like adding a Print() in a torque builtin and get > wild results. > I thought it was just Print()/torque but it seems something fundamentally > wrong, see my attached screenshot (I've checked the generated torque code, > and it looks fine). > I've also gotten weird results like random unrelated asserts failing. > > Here's what I've been doing: > 1) Checked out Chromium - git fetch chromium > 2) Successfully built the Chromium.app - gclient sync && gn gen > out/Default && autoninja -C out/Default chrome > 3) Make a change in the v8 subdirectory > 4) Rebuild - autoninja -C out/Default chrome > > Anyone else notice this issue? > Should I be running a different build command? Is there some cache I need > to clear? Clean and start fresh? > > ... I fear the answer is going to start with "go" and end with "ma"... > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
