Thanks for filing! I see it already got triaged :) On Tue, Nov 6, 2018 at 8:42 AM <[email protected]> wrote:
> Hi Yang, > > I created this bug: http://crbug.com/902231 > Unfortunately, I have no controls for CC-ing you or [email protected] > > > On Monday, November 5, 2018 at 3:04:22 PM UTC+8, Yang Guo wrote: >> >> The changes you made in step (3) are Torque files, right? Maybe the build >> configs are broken somehow. We should file a bug for [email protected] >> on this. >> >> Yang >> >> On Mon, Nov 5, 2018 at 3:34 AM <[email protected]> wrote: >> >>> v8_context_snapshot.bin not being rebuilt (or some dependant build >>> action) is the cause. >>> >>> If I *manually delete v8_context_snapshot.bin* before an incremental >>> build (autoninja -C out/Default chrome), everything appears to work. >>> Here's the play by play ( >>> https://media.giphy.com/media/WS2f9chKSVcF3Tv2Gh/giphy.mp4). >>> >>> Hopefully this helps someone keep hair on their head. :) >>> >>> On Saturday, November 3, 2018 at 5:30:09 AM UTC+8, [email protected] >>> wrote: >>>> >>>> I'm investigating a system health memory regression in old space, that >>>> I'm unable to reproduce in a standalone d8. >>>> >>>> I have a hunch what it is (external resource string type handling), but >>>> trying to verify a fix it actually works by running the chromium benchmark >>>> locally (with my changes in the v8 subdirectory). >>>> >>>> I suspect maybe it has something to do with me also moving the output >>>> directory (out/Default -> out/Default-withPatch) after a successful initial >>>> build and then trying then building again with v8 changes to the moved >>>> output dir. >>>> >>>> I also wonder if this is somehow related: >>>> https://chromium-review.googlesource.com/c/v8/v8/+/1304441 >>>> >>>> I'll try a fresh build, not move the output dir ever and dig up more >>>> info if I keep hitting the issue. >>>> >>>> Thanks. >>>> >>>> -- >>> -- >>> v8-dev mailing list >>> [email protected] >>> http://groups.google.com/group/v8-dev >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "v8-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
