The only investigating done was a look at the bug trackers, as noted in the email — So if it’s implemented, there are no compat risks, obviously.
The failure is probably fixed in the clusterfuzz fix CL out for review. > On Dec 6, 2018, at 8:17 PM, Sathya Gunasekaran <[email protected]> wrote: > >> On Thu, Dec 6, 2018 at 5:03 PM Adam Klein <[email protected]> wrote: >> >> LGTM, with a question >> >>> On Thu, Dec 6, 2018 at 2:03 PM Caitlin Potter <[email protected]> wrote: >>> >>> Contact Emails >>> [email protected], [email protected] >>> >>> Spec >>> >>> https://tc39.github.io/proposal-object-from-entries/ >>> >>> Summary >>> >>> Object.fromEntries() is a Stage 3 proposal introducing a new Object static >>> method to the ECMAScript standard library >>> which constructs a new JSObject from an iterable collection of key/value >>> pairs >>> >>> // Such that >>> Object.fromEntries( [ [ "key1", "value1" ], [ "key2", "value2" ] ] ); >>> >>> // Yields: >>> { >>> "key1": "value1", >>> "key2": "value2", >>> } >>> >>> Interoperability and compatibility risk >>> >>> Chromium/v8 seems to be the first engine to take on development of this >>> feature. I've been unable to find anything >>> regarding this on https://bugs.webkit.org, or https://bugzilla.mozilla.org. >>> Given that this is a reasonable startup project, >>> it's likely that any compat issues would be short lived. >> >> >> What do you mean by "reasonable startup project"? >> > > Yeah, I'm confused about this statement. Also, Firefox is shipping > this in Firefox 63 > (https://bugzilla.mozilla.org/show_bug.cgi?id=1469019), Safari has > this shipped in Tech Preview 65 > (https://bugs.webkit.org/show_bug.cgi?id=188481) and Chakra has this > implemented (https://github.com/Microsoft/ChakraCore/pull/5622). We're > the last one to implement this feature. > > I don't forsee any webcompat risks here. > >>> >>> Is this feature fully tested? >>> >>> We have a number of mjsunit tests, and are passing the full set of test262 >>> tests for this feature. Clusterfuzz has also >>> been dutifully finding faults, which have been promptly fixed and >>> incorporated into the v8 regression test suites. >>> > > From my testing, the current ToT fails the following test262: > - test262/built-ins/Object/fromEntries/requires-argument > > Can you please take a look? > >>> Tracking bug >>> >>> https://crbug.com/v8/8021 >>> >>> Link to entry on the Chrome Platform Status dashboard >>> >>> https://www.chromestatus.com/feature/5747878282657792 >>> >>> Requesting approval to ship? >>> >>> Yes. Note that since this is a V8/JS feature, this post is just an FYI to >>> blink-dev — no signoff from Blink API owners is >>> required. >>> >>> -- >>> -- >>> v8-dev mailing list >>> [email protected] >>> http://groups.google.com/group/v8-dev >>> --- >>> You received this message because you are subscribed to the Google Groups >>> "v8-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send an >>> email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >> >> -- >> -- >> v8-dev mailing list >> [email protected] >> http://groups.google.com/group/v8-dev >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
