Note: This is being tracked as https://crbug.com/v8/9555 now. I am just landing a fix for this <https://crrev.com/c/1720669>, and on the bug we are discussing whether we care enough about MSVC debug to add a bot to the waterfall.
On Mon, Jul 29, 2019 at 12:36 PM Jakob Kummerow <jkumme...@chromium.org> wrote: > if someone has the magic args.gn needed, I'd appreciate it. > > > For the record, you can easily get any build bot's args.gn: click through > to a specific build (in this case, e.g. > https://ci.chromium.org/p/v8/builders/try/v8_win64_msvc_compile_rel/b8906608002392908144), > and in the "Steps and Logs" section, look for "gn_args". > > Is this still supported? > > > I'm not sure what the official policy is at the moment. I think at the > very least, we would happily accept patches that maintain the MSVC build. > As you have figured out, we have Release-mode buildbot coverage for it; I > guess we assume that MSVC Debug builds are used and/or break rarely enough > that spending bot resources on them is hard to justify. > > > On Fri, Jul 26, 2019 at 1:05 AM billti via v8-dev <v8-dev@googlegroups.com> > wrote: > >> A colleague tracked it down to the CSA_ASSERT macro in >> code-stub-assembler.h failing in debug builds (looks like the tryjob only >> builds rel for MSVC). >> >> This change 16 days ago seems to have broken it: >> https://chromium-review.googlesource.com/c/v8/v8/+/1693002 . If I check >> out the parent commit (0fd3766) I can build debug fine in MSVC (after one >> more trivial MSVC fix in a DCHECK in wasm-module-builder.cc). It still >> gives the "/Zc:twoPhase" compiler option warning, but hopefully that's >> benign. >> >> I'll log a bug. >> >> On Thursday, July 25, 2019 at 3:38:20 PM UTC-7, bil...@microsoft.com >> wrote: >>> >>> Is this still supported? >>> >>> Trying to build the tip of master with 'is_clang = false' in args.gn >>> (and various other attempted options) is giving lots of different warnings >>> and failures, e.g. >>> >>> >>> cl : Command line warning D9002 : ignoring unknown option '/Zc:twoPhase' >>> .etc. >>> [501/1829] CXX >>> obj/torque_generated_initializers/proxy-set-property-tq-csa.obj >>> FAILED: obj/torque_generated_initializers/proxy-set-property-tq-csa.obj >>> .etc. >>> C:\src\v8\v8\src/codegen/code-stub-assembler.h(493): error C2059: syntax >>> error: ',' >>> .etc. >>> C:\src\v8\v8\src/objects/tagged-impl-inl.h(18): fatal error C1003: error >>> count exceeds 100; stopping compilation >>> .etc. >>> >>> It's the first time I've tried with MSVC, so may be doing something >>> wrong. (I have no issues with the default clang-based builds on the same >>> machine). >>> >>> I can see from task manager and the log output it is using the right >>> MSVC compiler (I tried with VS 2017 and VS 2019 installs), e.g. >>> >>> > ninja -t msvc -e environment.x64 -- "C:\Program Files (x86)\Microsoft >>> Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.22.27905\... >>> >>> I see some of the V8 tryjobs build with MSVC (e.g. >>> https://ci.chromium.org/p/v8/builders/try/v8_win64_msvc_compile_rel) >>> and seem to be working, so if someone has the magic args.gn needed, I'd >>> appreciate it. >>> >>> Thanks, >>> >>> - Bill >>> >> -- >> -- >> v8-dev mailing list >> v8-dev@googlegroups.com >> http://groups.google.com/group/v8-dev >> --- >> You received this message because you are subscribed to the Google Groups >> "v8-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to v8-dev+unsubscr...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/v8-dev/61cdf5a4-a276-4fcb-9bd7-ed37f1c40d49%40googlegroups.com >> <https://groups.google.com/d/msgid/v8-dev/61cdf5a4-a276-4fcb-9bd7-ed37f1c40d49%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > -- > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-dev/CAKSzg3Q1cq4Vwzs3mS-bFjTHHKFbwSWzhhGwjqANA2V56E%3DvdQ%40mail.gmail.com > <https://groups.google.com/d/msgid/v8-dev/CAKSzg3Q1cq4Vwzs3mS-bFjTHHKFbwSWzhhGwjqANA2V56E%3DvdQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- Clemens Hammacher Software Engineer cleme...@google.com Google Germany GmbH Erika-Mann-Straße 33 80636 München Geschäftsführer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAGO%3DqhB-gK3rXdZFkm7Pv_y5ec-OAjvFvBFv-ZEFQ1pTPLJ7BQ%40mail.gmail.com.
