I'd like to chime in for continued support of MSVC (with build regression automated tests). We embed V8 in a large project with many third party code components. Many of these components are not available as source so building with CLANG is not viable. We currently use V8 as a component build (DLL) but could also use V8 as a static library compiled with /MD. In general, most of our third party software comes with these too variants (static & dynamic libraries with /MD runtime).
I'd be happy to help in contributing / maintaining MSVC support but would need a primer on contributing and and some contacts as sounding boards for feedback and brainstorming. Chris Fischer On Thursday, July 25, 2019 at 6:38:20 PM UTC-4, bil...@microsoft.com wrote: > > Is this still supported? > > Trying to build the tip of master with 'is_clang = false' in args.gn (and > various other attempted options) is giving lots of different warnings and > failures, e.g. > > > cl : Command line warning D9002 : ignoring unknown option '/Zc:twoPhase' > .etc. > [501/1829] CXX > obj/torque_generated_initializers/proxy-set-property-tq-csa.obj > FAILED: obj/torque_generated_initializers/proxy-set-property-tq-csa.obj > .etc. > C:\src\v8\v8\src/codegen/code-stub-assembler.h(493): error C2059: syntax > error: ',' > .etc. > C:\src\v8\v8\src/objects/tagged-impl-inl.h(18): fatal error C1003: error > count exceeds 100; stopping compilation > .etc. > > It's the first time I've tried with MSVC, so may be doing something wrong. > (I have no issues with the default clang-based builds on the same machine). > > I can see from task manager and the log output it is using the right MSVC > compiler (I tried with VS 2017 and VS 2019 installs), e.g. > > > ninja -t msvc -e environment.x64 -- "C:\Program Files (x86)\Microsoft > Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.22.27905\... > > I see some of the V8 tryjobs build with MSVC (e.g. > https://ci.chromium.org/p/v8/builders/try/v8_win64_msvc_compile_rel) and > seem to be working, so if someone has the magic args.gn needed, I'd > appreciate it. > > Thanks, > > - Bill > -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/d9692c02-e07a-43f9-ba56-bd2812b5c627%40googlegroups.com.
