LGTM
http://codereview.chromium.org/660084/diff/1/2 File src/runtime.cc (right): http://codereview.chromium.org/660084/diff/1/2#newcode4157 src/runtime.cc:4157: // We do not include 0 so that we didn't have to treat +0 / -0 cases. didn't -> don't http://codereview.chromium.org/660084/diff/1/2#newcode4158 src/runtime.cc:4158: if (number > 0 && number <= Smi::kMaxValue) Please use braces around both the if and the else body. if (...) { ... } else { ... } http://codereview.chromium.org/660084/diff/1/2#newcode4169 src/runtime.cc:4169: Object* obj = args[0]; Just use args[0] in the CONVERT_NUMBER_CHECKED below? http://codereview.chromium.org/660084/diff/1/2#newcode4180 src/runtime.cc:4180: if (number > 0 && number <= Smi::kMaxValue) Please use braces here as well. Repeat the comment about not handling 0 because of the -0/+0 complications? http://codereview.chromium.org/660084 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
