This change fails to compile on MacOS in debug mode, with the error:
g++ -o obj/debug/runtime.o -c -Wall -Werror -W -Wno-unused-parameter
-Wnon-virtual-dtor -pedantic -m32 -g -O0 -ansi -mmacosx-version-min=10.4
-fno-rtti -fno-exceptions -fvisibility=hidden -Wall -Werror -W
-Wno-unused-parameter -Wnon-virtual-dtor -pedantic -m32 -g -O0 -ansi
-mmacosx-version-min=10.4 -DV8_TARGET_ARCH_IA32 -DENABLE_DISASSEMBLER
-DDEBUG
-DENABLE_DEBUGGER_SUPPORT -DV8_NATIVE_REGEXP -DV8_ENABLE_CHECKS
-DENABLE_LOGGING_AND_PROFILING -Isrc src/runtime.cc
cc1plus: warnings being treated as errors
src/runtime.cc: In function 'v8::internal::Object*
v8::internal::Runtime_NumberToJSInt32(v8::internal::Arguments)':
src/runtime.cc:4187: warning: control reaches end of non-void function
src/runtime.cc: In function 'v8::internal::Object*
v8::internal::Runtime_NumberToInteger(v8::internal::Arguments)':
src/runtime.cc:4163: warning: control reaches end of non-void function
scons: *** [obj/debug/runtime.o] Error 1
scons: done building targets (errors occurred during build).
program finished with exit code 2
elapsedTime=5.347686
http://codereview.chromium.org/660084
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev