Hello Rahul, such a patch should be fine. Thank you very much.
Cheers, Andreas On Mon, Jun 12, 2023 at 9:02 PM Rahul S Chaphalkar < [email protected]> wrote: > Hello, > I am looking to submit a patch to enable vtune support while building wee8 > library. This will be for bazel build. > Currently, the flag `v8_enable_vtunejit` is not supported in bazel, so I'd > be enabling this, conditionally enabling vtune code event handler in > wasm/c-api.cc, so that embedders that use wasm-c-api as opposed to v8's > embedder API (like Envoy) would be able to get vtune support. > If more details about this patch are needed here, I'm happy to provide > them, let me know. > > Thanks, > Rahul > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-dev/3828926f-b78f-428d-8351-b01c5122592bn%40googlegroups.com > <https://groups.google.com/d/msgid/v8-dev/3828926f-b78f-428d-8351-b01c5122592bn%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- Andreas Haas Software Engineer [email protected] Google Germany GmbH Erika-Mann-Straße 33 80636 München Geschäftsführer: Paul Manicle, Liana Sebastian Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAELSTvdn6Xs5p%2BgOA92aK2%2B-9extTtdtwFGfjG6n3LyZ3NBL6g%40mail.gmail.com.
