I still get the failure, even with this fix. But now its a different error:
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/src/inspector/inspector_string_conversions/v8-string-conversions.o.d -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DCR_XCODE_VERSION=1420 -DCR_CLANG_REVISION=\"llvmorg-18-init-1174-g2532b68f-1\" -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64 -DENABLE_GDB_JIT_INTERFACE -DV8_INTL_SUPPORT -DV8_ATOMIC_OBJECT_FIELD_WRITES -DV8_ENABLE_LAZY_SOURCE_POSITIONS -DV8_SHARED_RO_HEAP -DV8_WIN64_UNWINDING_INFO -DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH -DV8_SHORT_BUILTIN_CALLS -DV8_EXTERNAL_CODE_SPACE -DV8_ENABLE_MAGLEV -DV8_ENABLE_TURBOFAN -DV8_ENABLE_SYSTEM_INSTRUMENTATION -DV8_ENABLE_WEBASSEMBLY -DV8_ALLOCATION_FOLDING -DV8_ALLOCATION_SITE_TRACKING -DV8_ADVANCED_BIGINT_ALGORITHMS -DV8_STATIC_ROOTS -DV8_USE_ZLIB -DV8_USE_LIBM_TRIG_FUNCTIONS -DV8_ENABLE_WASM_SIMD256_REVEC -DV8_CODE_POINTER_SANDBOXING -DV8_ENABLE_MAGLEV_GRAPH_PRINTER -DV8_ENABLE_BUILTIN_JUMP_TABLE_SWITCH -DV8_ENABLE_EXTENSIBLE_RO_SNAPSHOT -DV8_COMPRESS_POINTERS -DV8_COMPRESS_POINTERS_IN_SHARED_CAGE -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_ENABLE_SANDBOX -DV8_DEPRECATION_WARNINGS -DV8_IMMINENT_DEPRECATION_WARNINGS -DCPPGC_CAGED_HEAP -DCPPGC_YOUNG_GENERATION -DCPPGC_POINTER_COMPRESSION -DCPPGC_SLIM_WRITE_BARRIER -DV8_TARGET_ARCH_X64 -DV8_HAVE_TARGET_OS -DV8_TARGET_OS_MACOS -DV8_RUNTIME_CALL_STATS -I../.. -Igen -I../../include -Igen/include -Wall -Wextra -Wimplicit-fallthrough -Wextra-semi -Wunreachable-code-aggressive -Wthread-safety -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration -Wenum-compare-conditional -Wno-ignored-pragma-optimize -Wno-deprecated-builtins -Wno-bitfield-constant-conversion -Wno-deprecated-this-capture -Wshadow -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing -fstack-protector -femit-dwarf-unwind=no-compact-unwind -fcolor-diagnostics -fmerge-all-constants -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 -ffp-contract=off -arch x86_64 -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -ffile-compilation-dir=. -no-canonical-prefixes -fno-omit-frame-pointer -g2 -gdwarf-aranges -Xclang -debug-info-kind=limited -isysroot ../../../../../../../../../Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk -mmacos-version-min=10.15 -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wmissing-field-initializers -Wunreachable-code -Wno-shadow -Wctad-maybe-unsupported -Wshorten-64-to-32 -Wno-invalid-offsetof -O3 -fvisibility=default -std=c++20 -Wno-trigraphs -fno-exceptions -fno-rtti -c ../../src/inspector/v8-string-conversions.cc -o obj/src/inspector/inspector_string_conversions/v8-string-conversions.o 181 <https://github.com/RedisGears/v8-build/actions/runs/5948918843/job/16133660874#step:7:182>In file included from ../../src/inspector/v8-string-conversions.cc:5: 182 <https://github.com/RedisGears/v8-build/actions/runs/5948918843/job/16133660874#step:7:183>../../src/inspector/v8-string-conversions.h:8:10: fatal error: 'uchar.h' file not found 183 <https://github.com/RedisGears/v8-build/actions/runs/5948918843/job/16133660874#step:7:184> 8 | #include <uchar.h> 184 <https://github.com/RedisGears/v8-build/actions/runs/5948918843/job/16133660874#step:7:185> | ^~~~~~~~~ 185 <https://github.com/RedisGears/v8-build/actions/runs/5948918843/job/16133660874#step:7:186>1 error generated. On Tuesday, 22 August 2023 at 20:00:07 UTC+3 Jakob Kummerow wrote: > https://chromium-review.googlesource.com/c/v8/v8/+/4793528 looks related. > Have you updated past that commit yet? > > > On Tue, Aug 22, 2023 at 5:16 PM Meir Shpilraien <[email protected]> wrote: > >> Hey, >> >> A few days ago we started to see failure on our mac build on the main >> branch (which we do not see on official version). The failure: >> ``` >> ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF >> obj/v8_base_without_compiler/frame-translation-builder.o.d >> -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DCR_XCODE_VERSION=1420 >> -DCR_CLANG_REVISION=\"llvmorg-18-init-1174-g2532b68f-1\" -D_DEBUG >> -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DCPPGC_VERIFY_HEAP -DENABLE_DISASSEMBLER >> -DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64 -DENABLE_GDB_JIT_INTERFACE >> -DOBJECT_PRINT -DVERIFY_HEAP -DV8_TRACE_MAPS -DV8_ENABLE_ALLOCATION_TIMEOUT >> -DV8_ENABLE_FORCE_SLOW_PATH -DV8_ENABLE_DOUBLE_CONST_STORE_CHECK >> -DV8_INTL_SUPPORT -DENABLE_HANDLE_ZAPPING -DV8_CODE_COMMENTS >> -DV8_ENABLE_DEBUG_CODE -DV8_ENABLE_HEAP_SNAPSHOT_VERIFY >> -DV8_SNAPSHOT_NATIVE_CODE_COUNTERS -DV8_ATOMIC_OBJECT_FIELD_WRITES >> -DV8_ENABLE_LAZY_SOURCE_POSITIONS -DV8_SHARED_RO_HEAP >> -DV8_WIN64_UNWINDING_INFO -DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH >> -DV8_SHORT_BUILTIN_CALLS -DV8_EXTERNAL_CODE_SPACE -DV8_ENABLE_MAGLEV >> -DV8_ENABLE_TURBOFAN -DV8_ENABLE_SYSTEM_INSTRUMENTATION >> -DV8_ENABLE_WEBASSEMBLY -DV8_ALLOCATION_FOLDING >> -DV8_ALLOCATION_SITE_TRACKING -DV8_ADVANCED_BIGINT_ALGORITHMS >> -DV8_STATIC_ROOTS -DV8_USE_ZLIB -DV8_USE_LIBM_TRIG_FUNCTIONS >> -DV8_ENABLE_WASM_SIMD256_REVEC -DV8_CODE_POINTER_SANDBOXING >> -DV8_ENABLE_MAGLEV_GRAPH_PRINTER -DV8_ENABLE_SLOW_TRACING >> -DV8_ENABLE_BUILTIN_JUMP_TABLE_SWITCH -DV8_ENABLE_EXTENSIBLE_RO_SNAPSHOT >> -DV8_ENABLE_CHECKS -DV8_COMPRESS_POINTERS >> -DV8_COMPRESS_POINTERS_IN_SHARED_CAGE -DV8_31BIT_SMIS_ON_64BIT_ARCH >> -DV8_ENABLE_SANDBOX -DV8_DEPRECATION_WARNINGS >> -DV8_IMMINENT_DEPRECATION_WARNINGS -DCPPGC_CAGED_HEAP >> -DCPPGC_YOUNG_GENERATION -DCPPGC_POINTER_COMPRESSION >> -DCPPGC_SLIM_WRITE_BARRIER -DV8_TARGET_ARCH_X64 -DV8_HAVE_TARGET_OS >> -DV8_TARGET_OS_MACOS -DDEBUG -DENABLE_SLOW_DCHECKS -DV8_RUNTIME_CALL_STATS >> -DABSL_ALLOCATOR_NOTHROW=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 >> -DUSE_CHROMIUM_ICU=1 -DU_ENABLE_TRACING=1 -DU_ENABLE_RESOURCE_TRACING=0 >> -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -I../.. >> -Igen -I../../include -Igen/include -I../../third_party/abseil-cpp >> -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n >> -I../../third_party/zlib -Wall -Wextra -Wimplicit-fallthrough -Wextra-semi >> -Wunreachable-code-aggressive -Wthread-safety -Wunguarded-availability >> -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi >> -Wloop-analysis -Wno-unneeded-internal-declaration >> -Wenum-compare-conditional -Wno-ignored-pragma-optimize >> -Wno-deprecated-builtins -Wno-bitfield-constant-conversion >> -Wno-deprecated-this-capture -Wshadow -fno-delete-null-pointer-checks >> -fno-ident -fno-strict-aliasing -fstack-protector-strong >> -femit-dwarf-unwind=no-compact-unwind -fcolor-diagnostics >> -fmerge-all-constants >> -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm >> -instcombine-lower-dbg-declare=0 -ffp-contract=off -arch x86_64 >> -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= >> -ffile-compilation-dir=. -no-canonical-prefixes >> -ftrivial-auto-var-init=pattern -fno-omit-frame-pointer -g2 -gdwarf-aranges >> -Xclang -debug-info-kind=limited -isysroot >> ../../../../../../../../../Applications/ >> Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk >> >> -mmacos-version-min=10.15 -Wheader-hygiene -Wstring-conversion >> -Wtautological-overlap-compare -Wmissing-field-initializers >> -Wunreachable-code -Wno-shadow -Wctad-maybe-unsupported -Wshorten-64-to-32 >> -Wno-invalid-offsetof -O0 -fvisibility=default -Wexit-time-destructors >> -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare >> -std=c++20 -Wno-trigraphs -fno-exceptions -fno-rtti -c >> ../../src/deoptimizer/frame-translation-builder.cc -o >> obj/v8_base_without_compiler/frame-translation-builder.o >> 1565 >> <https://github.com/RedisGears/v8-build/actions/runs/5909558127/job/16030273162#step:7:1566>In >> >> file included from ../../src/deoptimizer/frame-translation-builder.cc:5: >> 1566 >> <https://github.com/RedisGears/v8-build/actions/runs/5909558127/job/16030273162#step:7:1567>In >> >> file included from ../../src/deoptimizer/frame-translation-builder.h:10: >> 1567 >> <https://github.com/RedisGears/v8-build/actions/runs/5909558127/job/16030273162#step:7:1568>../../src/objects/deoptimization-data.h:96:24: >> >> error: implicit instantiation of undefined template 'std::vector<int>' >> 1568 >> <https://github.com/RedisGears/v8-build/actions/runs/5909558127/job/16030273162#step:7:1569> >> >> 96 | std::vector<int32_t> uncompressed_contents_; >> 1569 >> <https://github.com/RedisGears/v8-build/actions/runs/5909558127/job/16030273162#step:7:1570> >> >> | ^ >> 1570 >> <https://github.com/RedisGears/v8-build/actions/runs/5909558127/job/16030273162#step:7:1571> >> ../../../../../../../../../Applications/ >> Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/usr/include/c++/v1/iosfwd:259:28: >> >> note: template is declared here >> 1571 >> <https://github.com/RedisGears/v8-build/actions/runs/5909558127/job/16030273162#step:7:1572> >> >> 259 | class _LIBCPP_TEMPLATE_VIS vector; >> 1572 >> <https://github.com/RedisGears/v8-build/actions/runs/5909558127/job/16030273162#step:7:1573> >> >> | ^ >> 1573 >> <https://github.com/RedisGears/v8-build/actions/runs/5909558127/job/16030273162#step:7:1574>1 >> >> error generated. >> ``` >> I was wondering if something got broken recently? Or maybe we are doing >> something wrong? >> >> Thanks, >> Meir >> >> >> *Disclaimer* >> >> The information contained in this communication from the sender is >> confidential. It is intended solely for use by the recipient and others >> authorized to receive it. If you are not the recipient, you are hereby >> notified that any disclosure, copying, distribution or taking action in >> relation of the contents of this information is strictly prohibited and may >> be unlawful. >> >> -- >> >> Disclaimer The information contained in this communication from the sender is confidential. It is intended solely for use by the recipient and others authorized to receive it. If you are not the recipient, you are hereby notified that any disclosure, copying, distribution or taking action in relation of the contents of this information is strictly prohibited and may be unlawful. This email has been scanned for viruses and malware, and may have been automatically archived by Mimecast Ltd, an innovator in Software as a Service (SaaS) for business. Providing a safer and more useful place for your human generated data. Specializing in; Security, archiving and compliance. To find out more visit the Mimecast website. -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/d7e78863-97eb-46b9-ab3a-7fb8a7a6c86an%40googlegroups.com.
