FWIW, I don't think the #include of uchar.h is necessary. Looking at commit 182d9c05e78 it was added to get the definition of char16_t but that's an intrinsic type in C++. You only need that header when compiling C code.
On Mon, Aug 28, 2023 at 10:54 AM Jakob Kummerow <[email protected]> wrote: > > I don't know. Clearly something is different about your build setup. > > That #include was recently added: > https://chromium-review.googlesource.com/c/v8/v8/+/4789966 > Does it work if you change it from #include <uchar.h> to #include > "unicode/uchar.h" ? If so, feel free to submit a patch. > > > On Mon, Aug 28, 2023 at 8:56 AM Meir Shpilraien <[email protected]> wrote: >> >> Any idea what might be the issue here? We are still getting this last >> failure. >> >> On Wednesday, 23 August 2023 at 15:00:44 UTC+3 Meir Shpilraien wrote: >>> >>> I still get the failure, even with this fix. But now its a different error: >>> >>> ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF >>> obj/src/inspector/inspector_string_conversions/v8-string-conversions.o.d >>> -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 >>> -DCR_XCODE_VERSION=1420 >>> -DCR_CLANG_REVISION=\"llvmorg-18-init-1174-g2532b68f-1\" -DNDEBUG >>> -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 >>> -DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64 -DENABLE_GDB_JIT_INTERFACE >>> -DV8_INTL_SUPPORT -DV8_ATOMIC_OBJECT_FIELD_WRITES >>> -DV8_ENABLE_LAZY_SOURCE_POSITIONS -DV8_SHARED_RO_HEAP >>> -DV8_WIN64_UNWINDING_INFO -DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH >>> -DV8_SHORT_BUILTIN_CALLS -DV8_EXTERNAL_CODE_SPACE -DV8_ENABLE_MAGLEV >>> -DV8_ENABLE_TURBOFAN -DV8_ENABLE_SYSTEM_INSTRUMENTATION >>> -DV8_ENABLE_WEBASSEMBLY -DV8_ALLOCATION_FOLDING >>> -DV8_ALLOCATION_SITE_TRACKING -DV8_ADVANCED_BIGINT_ALGORITHMS >>> -DV8_STATIC_ROOTS -DV8_USE_ZLIB -DV8_USE_LIBM_TRIG_FUNCTIONS >>> -DV8_ENABLE_WASM_SIMD256_REVEC -DV8_CODE_POINTER_SANDBOXING >>> -DV8_ENABLE_MAGLEV_GRAPH_PRINTER -DV8_ENABLE_BUILTIN_JUMP_TABLE_SWITCH >>> -DV8_ENABLE_EXTENSIBLE_RO_SNAPSHOT -DV8_COMPRESS_POINTERS >>> -DV8_COMPRESS_POINTERS_IN_SHARED_CAGE -DV8_31BIT_SMIS_ON_64BIT_ARCH >>> -DV8_ENABLE_SANDBOX -DV8_DEPRECATION_WARNINGS >>> -DV8_IMMINENT_DEPRECATION_WARNINGS -DCPPGC_CAGED_HEAP >>> -DCPPGC_YOUNG_GENERATION -DCPPGC_POINTER_COMPRESSION >>> -DCPPGC_SLIM_WRITE_BARRIER -DV8_TARGET_ARCH_X64 -DV8_HAVE_TARGET_OS >>> -DV8_TARGET_OS_MACOS -DV8_RUNTIME_CALL_STATS -I../.. -Igen -I../../include >>> -Igen/include -Wall -Wextra -Wimplicit-fallthrough -Wextra-semi >>> -Wunreachable-code-aggressive -Wthread-safety -Wunguarded-availability >>> -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi >>> -Wloop-analysis -Wno-unneeded-internal-declaration >>> -Wenum-compare-conditional -Wno-ignored-pragma-optimize >>> -Wno-deprecated-builtins -Wno-bitfield-constant-conversion >>> -Wno-deprecated-this-capture -Wshadow -fno-delete-null-pointer-checks >>> -fno-ident -fno-strict-aliasing -fstack-protector >>> -femit-dwarf-unwind=no-compact-unwind -fcolor-diagnostics >>> -fmerge-all-constants >>> -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm >>> -instcombine-lower-dbg-declare=0 -ffp-contract=off -arch x86_64 >>> -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= >>> -ffile-compilation-dir=. -no-canonical-prefixes -fno-omit-frame-pointer -g2 >>> -gdwarf-aranges -Xclang -debug-info-kind=limited -isysroot >>> ../../../../../../../../../Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk >>> -mmacos-version-min=10.15 -Wheader-hygiene -Wstring-conversion >>> -Wtautological-overlap-compare -Wmissing-field-initializers >>> -Wunreachable-code -Wno-shadow -Wctad-maybe-unsupported -Wshorten-64-to-32 >>> -Wno-invalid-offsetof -O3 -fvisibility=default -std=c++20 -Wno-trigraphs >>> -fno-exceptions -fno-rtti -c ../../src/inspector/v8-string-conversions.cc >>> -o obj/src/inspector/inspector_string_conversions/v8-string-conversions.o >>> 181In file included from ../../src/inspector/v8-string-conversions.cc:5: >>> 182../../src/inspector/v8-string-conversions.h:8:10: fatal error: 'uchar.h' >>> file not found >>> 183 8 | #include <uchar.h> >>> 184 | ^~~~~~~~~ >>> 1851 error generated. >>>>> >>>>> > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-dev/CAKSzg3QC02R3tCgaQXcKYNmE7F6y1L8YQ-3%3Dk9WQAOZYTUhwaA%40mail.gmail.com. -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAHQurc_JLXUVw0LGPs2U8EiJp6Kz%3DxFF9M8Drkep5ciXc%2Bw8vQ%40mail.gmail.com.
