LGTM.
http://codereview.chromium.org/553117/diff/19001/18005 File src/ic.cc (right): http://codereview.chromium.org/553117/diff/19001/18005#newcode1494 src/ic.cc:1494: HandleScope scope; HandleScope could be moved down to before GetBinaryOpStub because you don't need a handle scope to create handle copies of the args (they're in the stack, so seen and updated on GC): { HandleScope scope; BinaryOpIC::TypeInfo type_info = ... ... if (!code.is_null()) { ... } } return *result; http://codereview.chromium.org/553117 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
