To submit patches to V8, please upload them to Gerrit. See https://v8.dev/docs/contribute.
Patches generally land on the main branch. Backmerges to old branches (such as 13.6) would need special justification. Note that illumos is officially unsupported by the core V8 team, i.e. it's only supported by interested community members such as yourself. That means: (1) You can pretty much do whatever you want, don't expect much feedback. Everyone has limited cycles, and "officially unsupported" means we're not going to spend our cycles on illumos (neither by fixing issues, nor by taking the time for in-depth reviews). If you want an in-depth review, find another illumos expert in the illumos community and work with them. (2) illumos-related patches should be specific to illumos and not run a risk of breaking (or complicating) anything else. So, as long as your patches are non-intrusive, getting them approved and landed should be easy. I for one have no plans to build or test V8 on illumos. Our CI infrastructure doesn't provide test coverage on illumos either (see "officially unsupported" above). On Fri, May 2, 2025 at 11:59 PM Dan McDonald < [email protected]> wrote: > Both have been tested on modern illumos (the still-open-source success to > OpenSolaris) by using Node.JS 24's recent import of V8 13.6. > > They are here for download: https://kebe.com/~danmcd/webrevs/V8-patches/ > > The first one is dependent on a modern V8 with the recent AIX patches from > Abdirahim Musse, but has a 13.6 variant already committed in Node 24's > post-13.6-import thanks to the folks at Node! > > The second fix forces a recent illumos version, but gets rid of a horrible > mismatch with madvise(3C) that we fixed in illumos-gate in 2022; we now use > `void *` where appropriate instead of `caddr_t`, which I know is > restricting Node's illumos/SmartOS Jenkins build agents. > > I don't know if anyone has set up the V8 build tooling on illumos lately > or ever, but I'm happy to assist modulo my limited cycles. Unblocking Node > on illumos was important, and Abdirahim's fix helped me arrive at the > appropriate illumos one for our VA48 process address space both in Node, > and for upstream V8. > > I will gladly accept any clues thrown my way. My only limitation is > cycles, as I'm a core member of the illumos team, as well as the lead for > illumos-distro SmartOS. > > Thank you! > Dan McDonald > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion visit > https://groups.google.com/d/msgid/v8-dev/8a7b2a40-f9e3-4f58-9d78-2a1b9ae45363n%40googlegroups.com > <https://groups.google.com/d/msgid/v8-dev/8a7b2a40-f9e3-4f58-9d78-2a1b9ae45363n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/d/msgid/v8-dev/CAKSzg3Tc%3DJ6quP043eYOF6LB3xfL4Xb1U_qfmqc6U8Ak-yLKDg%40mail.gmail.com.
