On Monday, May 5, 2025 at 6:59:02 AM UTC-4 Jakob Kummerow wrote:
To submit patches to V8, please upload them to Gerrit. See
https://v8.dev/docs/contribute.
I did read that... lotta tooling, and it's not clear I can use any of it on
illumos. I guess I can use MacOS for submissions. Also, I'm still in the
spin-down process of a set of Ms&As so I'm not sure under whose name I'd
register my company, or if they'd let me contribute as an individual.
Patches generally land on the main branch. Backmerges to old branches (such
as 13.6) would need special justification.
Node took the illumos-only patch for their import of 13.6, which was kind
and supportive of them. I'm not expecting V8 to accept backports. I hope
to have illumos changes upstream before the NEXT time Node updates their V8
revision.
Note that illumos is officially unsupported by the core V8 team, i.e. it's
only supported by interested community members such as yourself.
I noticed this in BUILD.gn:
` # TODO(infra): Add support for qnx, freebsd, openbsd, netbsd, and
solaris.`
Do you support Oracle Solaris? We aren't THAT much different from our
closed-source peer descendant.
That means:
(1) You can pretty much do whatever you want, don't expect much feedback.
Everyone has limited cycles, and "officially unsupported" means we're not
going to spend our cycles on illumos (neither by fixing issues, nor by
taking the time for in-depth reviews). If you want an in-depth review, find
another illumos expert in the illumos community and work with them.
Understood. Mostly these would be upstream pushes first tested in Node. I
think there are some Node folks who hang out here. I'm sure they'd like
upstream to not require Node-specific changes.
(2) illumos-related patches should be specific to illumos and not run a
risk of breaking (or complicating) anything else.
Yep. It's why I wanted to wait for the AIX one to LAND in V8, so I could
be out of their way.
So, as long as your patches are non-intrusive, getting them approved and
landed should be easy. I for one have no plans to build or test V8 on
illumos. Our CI infrastructure doesn't provide test coverage on illumos
either (see "officially unsupported" above).
My testing will be in the context of Node... you're an upstream, so just
think about it that way: A downstream trying to give back to upstream.
Thank you for the information. I'll move forward as I can.
Dan
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
"v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
To view this discussion visit
https://groups.google.com/d/msgid/v8-dev/ce4cab67-eee5-407f-a7f9-4812783d828bn%40googlegroups.com.
