LGTM
http://codereview.chromium.org/661469/diff/3001/2010 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/661469/diff/3001/2010#newcode7273 src/arm/codegen-arm.cc:7273: // If check failed combine both characters into signle halfword. signle -> single. Please add to the comment why the branch is after the orr. http://codereview.chromium.org/661469/diff/3001/2010#newcode7284 src/arm/codegen-arm.cc:7284: // Collect the two characters in a register. Isn't this already done above? http://codereview.chromium.org/661469/diff/3001/2010#newcode7304 src/arm/codegen-arm.cc:7304: __ sub(mask, mask, Operand(1)); Remove one of the empty lines. http://codereview.chromium.org/661469/diff/3001/2010#newcode7310 src/arm/codegen-arm.cc:7310: Operand(SymbolTable::kElementsStartOffset - kHeapObjectTag)); Please remove two of the empty lines. http://codereview.chromium.org/661469/diff/3001/2010#newcode7317 src/arm/codegen-arm.cc:7317: // symbol_table: symbol table This is now first_symbol_table_element and it does not contain the symbol table. http://codereview.chromium.org/661469/diff/3001/2007 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/661469/diff/3001/2007#newcode11182 src/ia32/codegen-ia32.cc:11182: __ ret(3 * kPointerSize); Good catch! http://codereview.chromium.org/661469 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
