LGTM
http://codereview.chromium.org/661469/diff/3001/2010 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/661469/diff/3001/2010#newcode7273 src/arm/codegen-arm.cc:7273: // If check failed combine both characters into signle halfword. signle -> single http://codereview.chromium.org/661469/diff/3001/2010#newcode7305 src/arm/codegen-arm.cc:7305: Remove extra empty line? http://codereview.chromium.org/661469/diff/3001/2010#newcode7310 src/arm/codegen-arm.cc:7310: Operand(SymbolTable::kElementsStartOffset - kHeapObjectTag)); Indentation one space off here? http://codereview.chromium.org/661469/diff/3001/2010#newcode7311 src/arm/codegen-arm.cc:7311: Remove extra empty lines. http://codereview.chromium.org/661469/diff/3001/2010#newcode7317 src/arm/codegen-arm.cc:7317: // symbol_table: symbol table symbol_table is not used below, so you should describe symbol_table_element here. http://codereview.chromium.org/661469/diff/3001/2010#newcode7324 src/arm/codegen-arm.cc:7324: Label next_probe[kProbes], next_probe_pop_mask[kProbes]; I don't think you need the pop_mask variant since you do not push the mask in this version. http://codereview.chromium.org/661469/diff/3001/2010#newcode7362 src/arm/codegen-arm.cc:7362: __ ldrh(scratch, FieldMemOperand(candidate, SeqAsciiString::kHeaderSize)); Loading a half-word puts zeros in the other halfword, right? http://codereview.chromium.org/661469/diff/3001/2010#newcode7542 src/arm/codegen-arm.cc:7542: __ strh(r3, MemOperand(r1)); Can you combine the add and the strh here and use a FieldMemOperand? strh(r3, FieldMemOperand(r0, SeqAsciiString::kHeaderSize))? http://codereview.chromium.org/661469/diff/3001/2007 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/661469/diff/3001/2007#newcode11182 src/ia32/codegen-ia32.cc:11182: __ ret(3 * kPointerSize); Well spotted! http://codereview.chromium.org/661469 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
