LGTM with some suggestions for cleanup.
http://codereview.chromium.org/668256/diff/1006/7 File src/ast.h (right): http://codereview.chromium.org/668256/diff/1006/7#newcode244 src/ast.h:244: // Will ToInt32 be immediately applied to the result of this function? Comment should say "Will ToInt32 (ECMA 262-3 9.5) or ToUunt32 (ECMA 262-3 9.6) be applied to the result of this expression?" I.e., mention ToUint32, don't say "immediately", "function" ==> "expression". http://codereview.chromium.org/668256/diff/1006/7#newcode260 src/ast.h:260: class SideEffectFreeField : public BitField<bool, 0, 1> {}; Comment here saying "BitFields have <type, start, size>." or some such. http://codereview.chromium.org/668256/diff/1006/8 File src/rewriter.cc (right): http://codereview.chromium.org/668256/diff/1006/8#newcode248 src/rewriter.cc:248: if (FLAG_safe_int32_compiler) { if (FLAG_...) { Slot* slot = var->slot(); if (slot != NULL) { ... http://codereview.chromium.org/668256/diff/1006/8#newcode430 src/rewriter.cc:430: node->expression()->set_to_int32(true); You could move this inside the switch inside the if, and put it before ADD and let it fall through. http://codereview.chromium.org/668256/diff/1006/8#newcode539 src/rewriter.cc:539: node->right()->side_effect_free()); Indentation is off. http://codereview.chromium.org/668256 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
