http://codereview.chromium.org/668256/diff/1006/7 File src/ast.h (right):
http://codereview.chromium.org/668256/diff/1006/7#newcode244 src/ast.h:244: // Will ToInt32 be immediately applied to the result of this function? On 2010/03/08 14:43:30, Kevin Millikin wrote:
Comment should say "Will ToInt32 (ECMA 262-3 9.5) or ToUunt32 (ECMA
262-3 9.6)
be applied to the result of this expression?"
I.e., mention ToUint32, don't say "immediately", "function" ==>
"expression". Done. http://codereview.chromium.org/668256/diff/1006/7#newcode260 src/ast.h:260: class SideEffectFreeField : public BitField<bool, 0, 1> {}; On 2010/03/08 14:43:30, Kevin Millikin wrote:
Comment here saying "BitFields have <type, start, size>." or some
such. Done. http://codereview.chromium.org/668256/diff/1006/8 File src/rewriter.cc (right): http://codereview.chromium.org/668256/diff/1006/8#newcode430 src/rewriter.cc:430: node->expression()->set_to_int32(true); I want to_int32 to be correct even if --nosafe-int32-compiler. Moved into the switch if flag is true. On 2010/03/08 14:43:30, Kevin Millikin wrote:
You could move this inside the switch inside the if, and put it before
ADD and
let it fall through.
Done. http://codereview.chromium.org/668256 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
