LGTM.
http://codereview.chromium.org/668257/diff/1/2 File src/data-flow.cc (right): http://codereview.chromium.org/668257/diff/1/2#newcode437 src/data-flow.cc:437: if (slot != NULL && I'm also checking for stack locals and parameters in many locations in the assigned variables analysis. This would be a candidate for a helper function. http://codereview.chromium.org/668257/diff/1/2#newcode501 src/data-flow.cc:501: Variable* var = expr->expression()->AsVariableProxy()->AsVariable(); Sometimes we use ...->AsVariableProxy()->var() and sometimes ...->AsVariableProxy()->AsVariable() This is not part of this change, but could we get rid of one of them? http://codereview.chromium.org/668257 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
