LGTM when missing failure check is added.
http://codereview.chromium.org/717001/diff/1/5 File src/ic.h (right): http://codereview.chromium.org/717001/diff/1/5#newcode97 src/ic.h:97: // Compute the current IC state based on the target stub and the receiver. target stub, receiver and name. http://codereview.chromium.org/717001/diff/1/3 File src/objects.cc (right): http://codereview.chromium.org/717001/diff/1/3#newcode3305 src/objects.cc:3305: Object* obj = EnsureCapacity(1, &key); EnsureCapacity can return a failure, please check for failure before using result. http://codereview.chromium.org/717001/diff/1/6 File src/objects.h (right): http://codereview.chromium.org/717001/diff/1/6#newcode3738 src/objects.h:3738: // Lookup code object in the cache. Returns code object if found. What is returned if not found? http://codereview.chromium.org/717001 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
