Everything except grisu3.cc reviewed.
http://codereview.chromium.org/619005/diff/10032/10037 File src/cached_powers.h (right): http://codereview.chromium.org/619005/diff/10032/10037#newcode42 src/cached_powers.h:42: // The following defines "implement" the interface between this file and the Avoid using quotes to qualify or weaken words. Just say implement. http://codereview.chromium.org/619005/diff/10032/10037#newcode45 src/cached_powers.h:45: // GRISU_CACHE_NAME(i) contains GRISU_CACHE_NAME(1) where only every every 'i'th every every http://codereview.chromium.org/619005/diff/10032/10037#newcode48 src/cached_powers.h:48: // The higher 'i' is the less elements we use. fewer elements http://codereview.chromium.org/619005/diff/10032/10047 File src/checks.h (right): http://codereview.chromium.org/619005/diff/10032/10047#newcode105 src/checks.h:105: Make sure this works on all platforms, without introducing compilation failures, by checking it in separately. Or else drop it. We have had troubles with this in the past. http://codereview.chromium.org/619005/diff/10032/10038 File src/diy_fp.h (right): http://codereview.chromium.org/619005/diff/10032/10038#newcode34 src/diy_fp.h:34: // This "Do It Yourself Floating Point" class implements a 64bit significand/int implements a floating point number with a uint64 significand and an int exponent. Normalized DiyFp numbers will have the top bit of the significand set, and multiplication and subtraction do not normalize their results. http://codereview.chromium.org/619005/diff/10032/10038#newcode48 src/diy_fp.h:48: // than other. The result will not be normalized. and the significand of this must be bigger than the significand of other. http://codereview.chromium.org/619005/diff/10032/10040 File src/powers_ten.h (right): http://codereview.chromium.org/619005/diff/10032/10040#newcode4 src/powers_ten.h:4: Add comment: When this header file is used by xxxx.h, only one of the arrays below is accessed, the smallest array that will work with the given values of alpha and gamma. The intention is that only this array will be linked into the compiled code by the compiler. http://codereview.chromium.org/619005/diff/10032/10044 File test/cctest/test-double.cc (right): http://codereview.chromium.org/619005/diff/10032/10044#newcode31 test/cctest/test-double.cc:31: // The last 52 bits + 1 hidden bit a position 52. The 52 mantissa bits, plus the implicit 1 in bit 52, as a UINT64. http://codereview.chromium.org/619005/diff/10032/10044#newcode94 test/cctest/test-double.cc:94: CHECK(!Double(1.7976931348623157e308).IsSpecial()); What about negative numbers? http://codereview.chromium.org/619005/diff/10032/10046 File tools/generate-ten-powers.scm (right): http://codereview.chromium.org/619005/diff/10032/10046#newcode30 tools/generate-ten-powers.scm:30: ;; bigloo -static-bigloo -o generate-ten-powers generate-ten-powers.scm Mention that this is a scheme script, and that bigloo is a scheme compiler? http://codereview.chromium.org/619005 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
