LGTM.
http://codereview.chromium.org/619005/diff/10032/10035 File src/grisu3.cc (right): http://codereview.chromium.org/619005/diff/10032/10035#newcode56 src/grisu3.cc:56: static bool RoundWeed(char* buffer, int len, uint64_t wp_W, uint64_t Delta, Comment these with a statement describing what they do. http://codereview.chromium.org/619005/diff/10032/10035#newcode69 src/grisu3.cc:69: // boundary_minus and boundary_plus are the boundaries between w and its Don't mix v and w in this comment. Probably use v only. Don't use y - just say x again. You could say "any number strictly between b_m and b_p will round to v when converted to double. http://codereview.chromium.org/619005/diff/10032/10035#newcode89 src/grisu3.cc:89: // In fact: scaled_w - w*10^k < 1ulp (unit in the last place) of scaled_w. Can't this be exactly 1 lulp off? If cached_power is off by 1/2 lulp, and the multiplication is off by 1/2 lulp? http://codereview.chromium.org/619005/diff/10032/10035#newcode106 src/grisu3.cc:106: // comma-number it will be updated. What is a comma-number? http://codereview.chromium.org/619005 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
