Also changed the value of an un-allocated code cache back to an empty fixed
array as using the undefined object caused problems when running without
snapshots. The undefined object was not initialized when the first empty
code
caches was set up causing a smi 0 to be set as the empty code cache for some
objects.
http://codereview.chromium.org/717001/diff/1/5
File src/ic.h (right):
http://codereview.chromium.org/717001/diff/1/5#newcode97
src/ic.h:97: // Compute the current IC state based on the target stub
and the receiver.
On 2010/03/09 09:30:38, Mads Ager wrote:
target stub, receiver and name.
Done.
http://codereview.chromium.org/717001/diff/1/3
File src/objects.cc (right):
http://codereview.chromium.org/717001/diff/1/3#newcode3305
src/objects.cc:3305: Object* obj = EnsureCapacity(1, &key);
On 2010/03/09 09:30:38, Mads Ager wrote:
EnsureCapacity can return a failure, please check for failure before
using
result.
Done.
http://codereview.chromium.org/717001/diff/1/6
File src/objects.h (right):
http://codereview.chromium.org/717001/diff/1/6#newcode3738
src/objects.h:3738: // Lookup code object in the cache. Returns code
object if found.
On 2010/03/09 09:30:38, Mads Ager wrote:
What is returned if not found?
undefined - comment updated.
http://codereview.chromium.org/717001
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
