LGTM

http://codereview.chromium.org/669061/diff/12001/13001
File src/array.js (right):

http://codereview.chromium.org/669061/diff/12001/13001#newcode1110
src/array.js:1110: if (arguments.length == 3) {
We usually do:

if (!IS_UNDEFINED(len))

http://codereview.chromium.org/669061/diff/12001/13009
File src/ia32/stub-cache-ia32.cc (right):

http://codereview.chromium.org/669061/diff/12001/13009#newcode1248
src/ia32/stub-cache-ia32.cc:1248:
Immediate(Factory::fixed_array_map()));
Identation one space off?

http://codereview.chromium.org/669061/diff/12001/13009#newcode1276
src/ia32/stub-cache-ia32.cc:1276: // Check if wrote not a smi.
wrote -> value is

http://codereview.chromium.org/669061

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to