http://codereview.chromium.org/811006/diff/8001/9003 File src/runtime.cc (right):
http://codereview.chromium.org/811006/diff/8001/9003#newcode5150 src/runtime.cc:5150: class YearMonthDate { Instead of having a class that does all the work in it's constructor, can't you have a static method that you pass the array in which to store the four components? http://codereview.chromium.org/811006/diff/8001/9003#newcode5154 src/runtime.cc:5154: int year, month, day; Make these private with accessors and follow the Google C++ code style and prefix the name of data members with an underscore: http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml. int year() const { return year_; } private: int year_; http://codereview.chromium.org/811006/diff/8001/9003#newcode5163 src/runtime.cc:5163: static const int days_in_year = 365; Constants like these should have names of the form: kDaysInYear (http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml). http://codereview.chromium.org/811006/diff/8001/9003#newcode5393 src/runtime.cc:5393: #ifdef DEBUG Please delete and just keep the assert below. http://codereview.chromium.org/811006/diff/8001/9003#newcode5447 src/runtime.cc:5447: #ifdef DEBUG Please remove this and just keep the ASSERT below. http://codereview.chromium.org/811006/diff/8001/9003#newcode5472 src/runtime.cc:5472: // ASSERT(args[1]->IsJSArray()); Remove. http://codereview.chromium.org/811006/diff/8001/9003#newcode5475 src/runtime.cc:5475: // printf("[Runtime_DateYMDFromTime] %f\n", t); Remove. http://codereview.chromium.org/811006 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
