LGTM with a couple of nits.
http://codereview.chromium.org/811006/diff/14001/15003 File src/runtime.cc (right): http://codereview.chromium.org/811006/diff/14001/15003#newcode5080 src/runtime.cc:5080: static const int day_from_month[] = {0, 31, 59, 90, 120, 151, Let's change these constants to follow the Google style as well? Sorry about that - I should have noticed on the previous code review. http://codereview.chromium.org/811006/diff/14001/15003#newcode5145 src/runtime.cc:5145: static const char kDayInYear[] = { Could you add a comment stating the start and end year for this table? http://codereview.chromium.org/811006/diff/14001/15003#newcode5246 src/runtime.cc:5246: static const char kMonthInYear[] = { Comment with start and end year for this table? http://codereview.chromium.org/811006/diff/14001/15003#newcode5350 src/runtime.cc:5350: int &year, int &month, int &day) { One parameter per line when splitting like this. Similarly for the methods below. http://codereview.chromium.org/811006 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
