LGTM.
http://codereview.chromium.org/1008004/diff/5001/6002 File src/runtime.cc (right): http://codereview.chromium.org/1008004/diff/5001/6002#newcode5330 src/runtime.cc:5330: // Must be SMI. Return the argument unchanged for all the other types SMI -> smi http://codereview.chromium.org/1008004/diff/5001/6002#newcode5335 src/runtime.cc:5335: CONVERT_DOUBLE_CHECKED(x, args[0]); CONVERT_DOUBLE_CHECKED checks for IsNumber too. But at this point we know that args[0] is a HeapNumber. Could you avoid the redundant check? http://codereview.chromium.org/1008004/diff/5001/6002#newcode5340 src/runtime.cc:5340: if (!negative && exponent <= kSmiValueSize - 3) { Just for my understanding: Is it kSmiValueSize - 3 because smis have one less positive integer than negative integers (-2^30 to 2^30 - 1)? http://codereview.chromium.org/1008004/diff/5001/6002#newcode5344 src/runtime.cc:5344: // if the magnitude is big enough, there's no place for fraction part. If we if -> If http://codereview.chromium.org/1008004 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
