Drive by comment:

Maybe add a note saying that this method assumes that the callsite does a
ToNumber on the input. If this has not been done by the callsite this will not follow spec (i.e., if we get a string as input this will also output that string
- but it should output NaN). I know that we are always guaranteed that this
happens from Math.round but this method could potentially be used from somewhere
else (e.g., date functions)

http://codereview.chromium.org/1008004

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to