LGTM Perhaps a RegistersProvided abstraction could reduce the ifdef ugliness?
http://codereview.chromium.org/1114001/diff/3001/4001 File src/arm/regexp-macro-assembler-arm.cc (right): http://codereview.chromium.org/1114001/diff/3001/4001#newcode651 src/arm/regexp-macro-assembler-arm.cc:651: // Set r0 to address of char before start of input start of input -> match start position. http://codereview.chromium.org/1114001/diff/3001/4005 File src/jsregexp.cc (right): http://codereview.chromium.org/1114001/diff/3001/4005#newcode345 src/jsregexp.cc:345: Handle<String> pattern, indent http://codereview.chromium.org/1114001/diff/3001/4005#newcode373 src/jsregexp.cc:373: #endif // V8_NATIVE_REGEXP V8 -> !V8 Actually I prefer the comment // ndef V8_NATIVE_REGEXP which better reflects the contents of the #if in the #else. http://codereview.chromium.org/1114001/diff/3001/4005#newcode384 src/jsregexp.cc:384: ASSERT(output.length() >= please move this assert into the ifdef below http://codereview.chromium.org/1114001/diff/3001/4005#newcode414 src/jsregexp.cc:414: // If result is RETRY, the string have changed representation, and we have -> has http://codereview.chromium.org/1114001/diff/3001/4005#newcode417 src/jsregexp.cc:417: // the, potentially, differen subject (the string can switch between en -> ent http://codereview.chromium.org/1114001/diff/3001/4005#newcode472 src/jsregexp.cc:472: 2 blank lines http://codereview.chromium.org/1114001/diff/3001/4006 File src/jsregexp.h (right): http://codereview.chromium.org/1114001/diff/3001/4006#newcode81 src/jsregexp.h:81: Handle<String> pattern, indent http://codereview.chromium.org/1114001/diff/3001/4006#newcode104 src/jsregexp.h:104: // an exeception is thrown, and this function returns negative. Unclear comment. You can't both throw an exception and return a value. http://codereview.chromium.org/1114001/diff/3001/4006#newcode110 src/jsregexp.h:110: // If successful, returns RE_SUCCESS and have set the capture positions have -> set http://codereview.chromium.org/1114001/diff/3001/4006#newcode113 src/jsregexp.h:113: // If execution fails, throws an exception and returns RE_EXCEPTION. Unclear again. http://codereview.chromium.org/1114001/diff/3001/4007 File src/string.js (right): http://codereview.chromium.org/1114001/diff/3001/4007#newcode419 src/string.js:419: Trailing spaces? http://codereview.chromium.org/1114001 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
