http://codereview.chromium.org/1114001/diff/3001/4001 File src/arm/regexp-macro-assembler-arm.cc (right):
http://codereview.chromium.org/1114001/diff/3001/4001#newcode651 src/arm/regexp-macro-assembler-arm.cc:651: // Set r0 to address of char before start of input On 2010/03/19 11:04:11, Erik Corry wrote:
start of input -> match start position.
Actually "start of the input string". This is the thing I changed here, the "-1" position is now relative to the entire string, not just the start of the match test. http://codereview.chromium.org/1114001/diff/3001/4002 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/1114001/diff/3001/4002#newcode10551 src/ia32/codegen-ia32.cc:10551: __ mov(edi, Operand(ecx, edx, times_int_size, 0)); Done. http://codereview.chromium.org/1114001/diff/3001/4005 File src/jsregexp.cc (right): http://codereview.chromium.org/1114001/diff/3001/4005#newcode373 src/jsregexp.cc:373: #endif // V8_NATIVE_REGEXP Changed to ndef. http://codereview.chromium.org/1114001/diff/3001/4005#newcode384 src/jsregexp.cc:384: ASSERT(output.length() >= On 2010/03/19 11:04:11, Erik Corry wrote:
please move this assert into the ifdef below
Done. http://codereview.chromium.org/1114001/diff/3001/4005#newcode472 src/jsregexp.cc:472: Ignored, per offline discussion. http://codereview.chromium.org/1114001/diff/3001/4006 File src/jsregexp.h (right): http://codereview.chromium.org/1114001/diff/3001/4006#newcode81 src/jsregexp.h:81: Handle<String> pattern, On 2010/03/19 11:04:11, Erik Corry wrote:
indent
Done. http://codereview.chromium.org/1114001/diff/3001/4006#newcode104 src/jsregexp.h:104: // an exeception is thrown, and this function returns negative. Reworded. http://codereview.chromium.org/1114001/diff/3001/4006#newcode113 src/jsregexp.h:113: // If execution fails, throws an exception and returns RE_EXCEPTION. Reworded. http://codereview.chromium.org/1114001/diff/3001/4007 File src/string.js (right): http://codereview.chromium.org/1114001/diff/3001/4007#newcode419 src/string.js:419: On 2010/03/19 11:04:11, Erik Corry wrote:
Trailing spaces?
Done. http://codereview.chromium.org/1114001 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
