Some comments below, but it LGTM.
I will prefer a preprocessor directive for switching between
implementations,
and only go for a branch if the amoint of #ifdef/#endif's we have to deal
with
during the transition explodes.
http://codereview.chromium.org/1105009/diff/1/2
File include/v8-profiler.h (right):
http://codereview.chromium.org/1105009/diff/1/2#newcode80
include/v8-profiler.h:80: * Returns the number, 1-based, of the line
where the function originates.
We are not consistent here, as Message::GetLineNumber() returns 1-based
line numbers whereas Function::GetScriptLineNumber() and the debugger
returns zero based line numbers. I have bees advocating for zero based
as that is what we use internally, but I am not so sure anymore. However
we should have a constant for information not available as
Function::kLineOffsetNotFound. Maybe using a shared constant for this
will be the best, and -1 will fit in both schemes.
http://codereview.chromium.org/1105009/diff/1/2#newcode88
include/v8-profiler.h:88: */
Should we consider using uint64_t and change to a higher resolution than
milliseconds?
http://codereview.chromium.org/1105009/diff/1/2#newcode118
include/v8-profiler.h:118: /** Returns CPU profile UID (assigned by the
profiler.) */
UID -> ID?
http://codereview.chromium.org/1105009/diff/1/2#newcode133
include/v8-profiler.h:133: * Interface for controlling CPU profiling in
V8.
On need for "in V8".
http://codereview.chromium.org/1105009
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
