On 2010/03/26 13:49:15, zundel wrote:
http://codereview.chromium.org/1105009/diff/1002/3001
File include/v8-profiler.h (right):
http://codereview.chromium.org/1105009/diff/1002/3001#newcode129
include/v8-profiler.h:129: };
One thing I love about the v8 profiling data is that it classifies time
by VM
state (compiling, garbage collection, etc). Do you anticipate a way of
exposing
that information?
I can easily add overall statistics of ticks count per VM state.
http://codereview.chromium.org/1105009/diff/1002/3001#newcode152
include/v8-profiler.h:152: * profiles with the same title are silently
ignored.
*/
Should this function return a uid for use in GetProfile(uid) ?
This is the scenario of start / stop usage:
StartProfiling("name");
profile = StopProfiling("name");
now 'profile' is available for UI.
This is the scenario of GetProfile usage:
Get list of profile entries using GetProfilesCount / GetProfile(index). Now
you
have uids, so when an individual profile is about to be opened on ui, it
can be
retrieved using GetProfile(uid) (ugh, I actually renamed it into
FindProfile to
avoid confusion.)
http://codereview.chromium.org/1105009/diff/1002/3001#newcode153
include/v8-profiler.h:153: static void StartProfiling(Handle<String>
title =
Handle<String>());
for starting/stopping profiles automatically, I don't care so much about
the
names (they aren't going to be ready by a human). Could we come up with
a way
for a unique name be assigned automatically? Same with stopping the
profile.
I
would want some kind of handle (uid?) returned from StartProfile to use to
turn
this one off.
Well, in WebKit for some reason they use string names which they generate
automatically, when user presses "Start / Stop profiling" button. And string
names are used for profiles started via 'console' object. Using only numeric
uids will require managing (name, uid) pairs externally. Adding an
overloaded
version that accepts numeric uids instead of names looks like cluttering an
interface. So, the current approach seems sufficient.
http://codereview.chromium.org/1105009
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
