LGTM
http://codereview.chromium.org/1249002/diff/1/3 File src/number-info.h (right): http://codereview.chromium.org/1249002/diff/1/3#newcode51 src/number-info.h:51: // We know is's a primitive type. is's -> it is http://codereview.chromium.org/1249002/diff/1/3#newcode71 src/number-info.h:71: int answer = type_ & 15; Please use hex for things that are bit-oriented. http://codereview.chromium.org/1249002/diff/1/3#newcode83 src/number-info.h:83: t = (t != kUnknownType) ? static_cast<Type>(t | 16) : t; Can we use kPrimitiveType here instead of 16. Also I think it's clearer to have (x == y) ? ... : ... instead of (x != y) ? ... : ... http://codereview.chromium.org/1249002/diff/1/3#newcode161 src/number-info.h:161: kPrimitiveType = 16, Hex. http://codereview.chromium.org/1249002 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
