http://codereview.chromium.org/1249002/diff/1/3 File src/number-info.h (right):
http://codereview.chromium.org/1249002/diff/1/3#newcode51 src/number-info.h:51: // We know is's a primitive type. On 2010/03/24 12:18:15, Erik Corry wrote:
is's -> it is
Done. http://codereview.chromium.org/1249002/diff/1/3#newcode71 src/number-info.h:71: int answer = type_ & 15; On 2010/03/24 12:18:15, Erik Corry wrote:
Please use hex for things that are bit-oriented.
Done. http://codereview.chromium.org/1249002/diff/1/3#newcode83 src/number-info.h:83: t = (t != kUnknownType) ? static_cast<Type>(t | 16) : t; On 2010/03/24 12:18:15, Erik Corry wrote:
Can we use kPrimitiveType here instead of 16. Also I think it's
clearer to have
(x == y) ? ... : ... instead of (x != y) ? ... : ...
Done. http://codereview.chromium.org/1249002/diff/1/3#newcode161 src/number-info.h:161: kPrimitiveType = 16, On 2010/03/24 12:18:15, Erik Corry wrote:
Hex.
Done. (for all enum values) http://codereview.chromium.org/1249002 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
