Anders, yes, I thought about those properties stuff as well, however my idea was to make those properties just faster, but if we could live w/o them in some case (and I guess we can), it's even better.
And no, it's not quite a review yet, so if we're going to cache it, we definitely need some limit, but I was looking to understand where we spend our time first :) Anyway, thanks a lot for your comments. (I am explicitly cc'ing Lasse and Erik in case they missed this thread on groups.) yours, anton. On Thu, Mar 25, 2010 at 8:36 AM, <[email protected]> wrote: > drive-by comments > > Lasse/Erik, is there some way we can make use of the regexp code w/o all the > property setting stuff - given that we know we'll only make this one > specific > exec call? > > > > > http://codereview.chromium.org/1207004/diff/1/2 > File src/string.js (right): > > http://codereview.chromium.org/1207004/diff/1/2#newcode530 > src/string.js:530: if (IS_UNDEFINED(regexp)) { > Maybe reset cache at size 10, 100 or 1000 to avoid large memory increase > and longer lookup times. > > http://codereview.chromium.org/1207004 > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
