Reviewers: Mads Ager,
Message:
Mads,
may you have a look?
Description:
Omit write barrier when setting trimmed elements.
Please review this at http://codereview.chromium.org/1310002
Affected files:
M src/builtins.cc
Index: src/builtins.cc
diff --git a/src/builtins.cc b/src/builtins.cc
index
122fbba2c4aac4464c2a5bc1d37cf66d283b30bb..0f338e1823b1e8b82bc0d55b9491fec4fa1387c1
100644
--- a/src/builtins.cc
+++ b/src/builtins.cc
@@ -495,7 +495,8 @@ BUILTIN(ArrayShift) {
}
if (Heap::new_space()->Contains(elms)) {
- array->set_elements(LeftTrimFixedArray(elms));
+ // As elms are in new space, no need in write barrier.
+ array->set_elements(LeftTrimFixedArray(elms), SKIP_WRITE_BARRIER);
} else {
// Shift the elements.
AssertNoAllocation no_gc;
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
