Reviewers: Mads Ager,
Message:
And another small review for you, Mads.
Most important point is change from undefined to holes which is crucial.
Description:
Slightly faster variant of Array.push.
Please review this at http://codereview.chromium.org/1265003
Affected files:
M src/ia32/stub-cache-ia32.cc
Index: src/ia32/stub-cache-ia32.cc
diff --git a/src/ia32/stub-cache-ia32.cc b/src/ia32/stub-cache-ia32.cc
index
e554a31c7166b3bd8055ac8253c48f213ae6a9d9..d330b1c6975fb8e5f87790547cb18fe808718d30
100644
--- a/src/ia32/stub-cache-ia32.cc
+++ b/src/ia32/stub-cache-ia32.cc
@@ -1251,8 +1251,7 @@ Object*
CallStubCompiler::CompileArrayPushCall(Object* object,
__ j(not_equal, &miss);
if (argc == 1) { // Otherwise fall through to call builtin.
- Label call_builtin, exit, with_rset_update,
- attempt_to_grow_elements, finish_push;
+ Label call_builtin, exit, with_rset_update, attempt_to_grow_elements;
// Get the array's length into eax and calculate new length.
__ mov(eax, FieldOperand(edx, JSArray::kLengthOffset));
@@ -1278,8 +1277,6 @@ Object*
CallStubCompiler::CompileArrayPushCall(Object* object,
__ mov(ecx, Operand(esp, argc * kPointerSize));
__ mov(Operand(edx, 0), ecx);
- __ bind(&finish_push);
-
// Check if value is a smi.
__ test(ecx, Immediate(kSmiTagMask));
__ j(not_zero, &with_rset_update);
@@ -1321,7 +1318,7 @@ Object*
CallStubCompiler::CompileArrayPushCall(Object* object,
__ mov(Operand(edx, 0), ecx);
for (int i = 1; i < kAllocationDelta; i++) {
__ mov(Operand(edx, i * kPointerSize),
- Immediate(Factory::undefined_value()));
+ Immediate(Factory::the_hole_value()));
}
// Restore receiver to edx as finish sequence assumes it's here.
@@ -1332,7 +1329,8 @@ Object*
CallStubCompiler::CompileArrayPushCall(Object* object,
Immediate(kAllocationDelta));
__ mov(FieldOperand(edx, JSArray::kLengthOffset), eax);
- __ jmp(&finish_push);
+ // Elements are in new space, so no remembered set updates are
necessary.
+ __ ret((argc + 1) * kPointerSize);
__ bind(&call_builtin);
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
